Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PubMatic: Remove req.ext.prebid from bid requests #4092

Merged
merged 1 commit into from
Dec 16, 2024
Merged

PubMatic: Remove req.ext.prebid from bid requests #4092

merged 1 commit into from
Dec 16, 2024
+16 −99

Conversation

pm-viral-vala
Copy link
Contributor

@pm-viral-vala pm-viral-vala commented Dec 6, 2024 •
edited
Loading

Hi Team,

The PubMatic Adapter is currently not utilizing the req.ext.prebid object from the backend. As this parameter is not being used, we can safely skip passing it in the PubMatic Adapter requests.

To address this, I am raising a PR to remove the req.ext.prebid parameter from PubMatic requests.

Let me know if you have any concerns or require further input.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, ba4567c

pubmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:85:	MakeRequests				93.4%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:190:	validateAdSlot				91.3%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:233:	assignBannerSize			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:241:	assignBannerWidthAndHeight		100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:249:	parseImpressionObject			91.7%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:340:	extractPubmaticExtFromRequest		96.6%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:391:	getAlternateBidderCodesFromRequestExt	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:409:	addKeywordsToExt			85.7%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:423:	MakeBids				90.7%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:505:	getNativeAdm				90.9%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:527:	getMapFromJSON				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:539:	populateFirstPartyDataImpAttributes	100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:552:	populateAdUnitKey			100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:567:	populateDctrKey				85.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:617:	getStringArray				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:630:	getBidType				100.0%
github.com/prebid/prebid-server/v3/adapters/pubmatic/pubmatic.go:650:	Builder					100.0%
total:									(statements)				93.1%

@pm-viral-vala pm-viral-vala changed the title pubmatic: remove req.ext.prebid from pubmatic adapter request PubMatic: remove req.ext.prebid from pubmatic adapter request Dec 6, 2024
@pm-viral-vala pm-viral-vala marked this pull request as ready for review December 6, 2024 09:39
@pm-viral-vala pm-viral-vala changed the title PubMatic: remove req.ext.prebid from pubmatic adapter request PubMatic: Removing req.ext.prebid from PubMatic Adapter Dec 6, 2024
@bsardo bsardo changed the title PubMatic: Removing req.ext.prebid from PubMatic Adapter PubMatic: Remove req.ext.prebid from bid requests Dec 13, 2024
@przemkaczmarek przemkaczmarek self-requested a review December 16, 2024 11:38
@bsardo bsardo merged commit 620bf95 into prebid:master Dec 16, 2024
5 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Dec 16, 2024
Closed
@bsardo bsardo mentioned this pull request Dec 16, 2024
Merged
scr-oath pushed a commit to scr-oath/prebid-server that referenced this pull request Dec 16, 2024
@pm-viral-vala @scr-oath
PubMatic: Remove req.ext.prebid from bid requests (prebid#4092)
4ae4b85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pm-isha-bharti pm-isha-bharti

@bsardo bsardo

@przemkaczmarek przemkaczmarek

Assignees

@bsardo bsardo

@przemkaczmarek przemkaczmarek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pm-viral-vala @bsardo @pm-isha-bharti @przemkaczmarek